rahil-c commented on code in PR #9722: URL: https://github.com/apache/iceberg/pull/9722#discussion_r1491407208
########## core/src/main/java/org/apache/iceberg/inmemory/InMemoryFileIO.java: ########## @@ -28,7 +28,7 @@ public class InMemoryFileIO implements FileIO { - private final Map<String, byte[]> inMemoryFiles = Maps.newConcurrentMap(); + private static final Map<String, byte[]> inMemoryFiles = Maps.newConcurrentMap(); Review Comment: +1 for static and for using proper casing of variable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org