geruh opened a new pull request, #9722: URL: https://github.com/apache/iceberg/pull/9722
This PR addresses the issue with InMemoryFileIO not being resolved by the RESTCatalog Tests identified in #9604. In the RESTCatalog tests are backed by the `InMemoryCatalog` which uses `InMemoryFileIO`. But the `ResolvingFileIO` can't resolve this FileIO, and if we pass in the FileIO into the `RESTCatalog` there will be two instances of the `InMemoryFileIO`. Therefore, this change will ensure that there is shared access to the files across all the instances of the `InMemoryFileIO`. For more information: #9604 ## Testing Running and setting a break point on this method: * https://github.com/apache/iceberg/blob/50fb4004d299737fcbae6526e1743dd197c9242d/core/src/test/java/org/apache/iceberg/catalog/CatalogTests.java#L1386 ### Before #### InMemoryFileIO files <img width="1142" alt="Screenshot 2024-02-13 at 3 08 45 PM" src="https://github.com/apache/iceberg/assets/19402187/2c998db9-6046-4225-83bc-3546ae404013";> #### ResolvingFileIO files <img width="1326" alt="Screenshot 2024-02-13 at 3 03 49 PM" src="https://github.com/apache/iceberg/assets/19402187/ce30ad09-2fb6-4727-97ff-37eebd40b3b6";> ### After <img width="1235" alt="Screenshot 2024-02-13 at 2 41 44 PM" src="https://github.com/apache/iceberg/assets/19402187/e53fd59d-4b37-4280-8398-4c2fa7ee21c6";> ### Build `./gradlew build` ``` BUILD SUCCESSFUL in 49m 38s 452 actionable tasks: 216 executed, 236 up-to-date 2:32:59 PM: Execution finished 'build'. ``` cc: @nastra @amogh-jahagirdar @jackye1995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
