nastra commented on code in PR #9641:
URL: https://github.com/apache/iceberg/pull/9641#discussion_r1477806683
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/data/IcebergWriter.java:
##########
@@ -52,20 +51,23 @@ public IcebergWriter(Table table, String tableName,
IcebergSinkConfig config) {
private void initNewWriter() {
this.writer = Utilities.createTableWriter(table, tableName, config);
- // FIXME: update this when the record converter is added
- // this.recordConverter = new RecordConverter(table, config);
+ this.recordConverter = new RecordConverter(table, config);
}
@Override
public void write(SinkRecord record) {
try {
+ // TODO: config to handle tombstones instead of always ignoring?
Review Comment:
this line can probably be removed as it already exists right below this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
