syun64 commented on code in PR #358:
URL: https://github.com/apache/iceberg-python/pull/358#discussion_r1477128027
##########
pyiceberg/catalog/rest.py:
##########
@@ -450,6 +450,10 @@ def create_table(
iceberg_schema = self._convert_schema_if_needed(schema)
iceberg_schema = assign_fresh_schema_ids(iceberg_schema)
+ properties = properties.copy()
Review Comment:
I'm realizing that in the java code base,
**write.parquet.compression-codec** is a [table
property](https://github.com/apache/iceberg/blob/fb02bd2d713c9bef8b8ccee334f6d65087c344b2/core/src/main/java/org/apache/iceberg/TableProperties.java#L144C30-L144C49),
that can be overridden as a [runtime
option](https://iceberg.apache.org/docs/latest/spark-configuration/#write-options)
on write. It doesn't seem to be a catalog property.
Does it make sense to keep this logic to copy these properties from the
catalog properties, or should we simply rely on the users to [set these as
table
properties](https://github.com/apache/iceberg-python/blob/e385e7757cac08380a7578cf5a230bd62e88bb36/pyiceberg/catalog/rest.py#L448)
on table creation for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
