syun64 commented on code in PR #358:
URL: https://github.com/apache/iceberg-python/pull/358#discussion_r1477127850
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1720,13 +1720,22 @@ def write_file(table: Table, tasks:
Iterator[WriteTask]) -> Iterator[DataFile]:
except StopIteration:
pass
+ compression_codec = table.properties.get("write.parquet.compression-codec")
+ compression_level = table.properties.get("write.parquet.compression-level")
+ if compression_codec == "uncompressed":
+ compression_options = {"compression": "none"}
+ else:
Review Comment:
Sorry for the confusion. I was trying to find an alternative to using the
string "\<not set\>" to emulate the case where write.parquet.compression-codec
isn't set in the test case below. The issue seems to be with the [pydantic data
model](https://github.com/apache/iceberg-python/blob/e385e7757cac08380a7578cf5a230bd62e88bb36/pyiceberg/typedef.py#L76)
for `Properties` when trying to pass a None value on table creation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
