aokolnychyi commented on code in PR #9629:
URL: https://github.com/apache/iceberg/pull/9629#discussion_r1476991582
##########
core/src/main/java/org/apache/iceberg/PartitionData.java:
##########
@@ -171,6 +169,10 @@ public PartitionData copy() {
return new PartitionData(this);
}
+ public PartitionData copyFor(StructLike partition) {
Review Comment:
I am not entirely happy too. I followed what we did in other places like
StructLikeProjection.
Do we really need PartitionData here? What if we simply create a container
struct backed by an array and use it?
My worry with emptyCopy() is that the result object is in a weird state, I
am not sure it is actually better than copyFor().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
