amogh-jahagirdar commented on code in PR #9629:
URL: https://github.com/apache/iceberg/pull/9629#discussion_r1476890643
##########
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##########
@@ -188,23 +189,6 @@ public static <T extends PartitionScanTask>
List<ScanTaskGroup<T>> planTaskGroup
return taskGroups;
}
- private static StructLike projectGroupingKey(
- StructProjection groupingKeyProjection,
- Types.StructType groupingKeyType,
- StructLike partition) {
-
- PartitionData groupingKey = new PartitionData(groupingKeyType);
Review Comment:
Just for my understanding, the repeated calling of this constructor was
expensive because the repeated data array initialization (and possibly the
determining of the partitionType via `AvroSchemaUtil.convert`)? And now we
avoid repeatedly performing those computations by having a `PartitionData` be
initialized with a "template" just once for all tasks and then replace the
actual data in `PartitionData#copyFor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
