abmo-x commented on code in PR #9619:
URL: https://github.com/apache/iceberg/pull/9619#discussion_r1476934235
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -108,7 +108,10 @@ public void initialize(String name, Map<String, String>
properties) {
"Cannot initialize HadoopCatalog because warehousePath must not be
null or empty");
this.catalogName = name;
- this.warehouseLocation =
LocationUtil.stripTrailingSlash(inputWarehouseLocation);
+ this.warehouseLocation = inputWarehouseLocation;
+ if (!warehouseLocation.endsWith("://")) {
Review Comment:
Makes sense, as the util was also used for file paths I didn't put it in
there.
moved it into LocationUtil and added tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
