liurenjie1024 commented on issue #177: URL: https://github.com/apache/iceberg-rust/issues/177#issuecomment-1925047108
I remember why we use `expect` for `TableMetadata` serialization, see [this comment](https://github.com/apache/iceberg-rust/blob/c91aeaec2aa713a1efdc513e1769220dd53cf443/crates/iceberg/src/spec/table_metadata.rs#L51). But I still agree that it would be best not to panic in a serious lib which may crash programs. >serde does not support the attribute try_into. https://github.com/serde-rs/serde/issues/1524 The into attribute requires From. Converting to TryFrom requires us to manually implement a serializer. Yes, it seems we still need to implement Serialization/Deserialization manually, but it's still a wrapper of the conversion from `TableMetadataEnum`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
