zeodtr commented on issue #177: URL: https://github.com/apache/iceberg-rust/issues/177#issuecomment-1924916131
@Fokko @liurenjie1024 I think this issue has not been resolved, since I'm kind of disagree with the pull request. What I'm concerned about are as follows: * `expect()` also should not be used since it ends the program with panic just like `unwrap()`. In a production program that's unacceptable, especially for a server program. * It might not be enough to just replace `unwrap()` with `?` in `ManifestListWriter`'s write-related codes. In `ManifestWriter`, it also adds an appropriate error message. Please see: https://github.com/apache/iceberg-rust/blob/9ae9e13fb48ea8af20d76644f27dcb2fc8773396/crates/iceberg/src/spec/manifest.rs#L295 Could you please reopen this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
