aokolnychyi commented on code in PR #9561:
URL: https://github.com/apache/iceberg/pull/9561#discussion_r1468127155


##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -354,10 +354,6 @@ private DistributionMode 
copyOnWriteMergeDistributionMode() {
     if (mergeModeName != null) {
       DistributionMode mergeMode = DistributionMode.fromName(mergeModeName);
       return adjustWriteDistributionMode(mergeMode);
-
-    } else if (table.spec().isPartitioned()) {

Review Comment:
   This was actually done on purpose as INSERT and MERGE operations have 
different use cases. I still believe using `range` in MERGE should be avoided, 
if possible. I have never seen a use case at a reasonable scale that performed 
well with `range` in MERGE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to