allod commented on code in PR #9561:
URL: https://github.com/apache/iceberg/pull/9561#discussion_r1468060129
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java:
##########
@@ -1708,14 +1708,12 @@ public void
testDefaultCopyOnWriteMergePartitionedSortedTable() {
table.replaceSortOrder().desc("id").commit();
- Expression[] expectedClustering = new Expression[]
{Expressions.identity("date")};
- Distribution expectedDistribution =
Distributions.clustered(expectedClustering);
-
SortOrder[] expectedOrdering =
new SortOrder[] {
Expressions.sort(Expressions.column("date"),
SortDirection.ASCENDING),
Expressions.sort(Expressions.column("id"), SortDirection.DESCENDING)
};
+ Distribution expectedDistribution =
Distributions.ordered(expectedOrdering);
Review Comment:
The asserted expected distribution is different.
Before it was clustered on the `date` field, after it is ordered by `date`
and `id` fields.
I've updated this test as otherwise the test fails with following error:
```
java.lang.AssertionError: Distribution must match
expected:<ClusteredDistribution(date)>
but was:<OrderedDistribution(date ASC NULLS FIRST, id DESC NULLS LAST)>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
