wolfeidau commented on code in PR #51: URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1467124542
########## catalog/catalog.go: ########## @@ -0,0 +1,65 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package catalog + +import ( + "context" + "errors" + + "github.com/apache/iceberg-go/table" + "github.com/aws/aws-sdk-go-v2/aws" +) + +type CatalogType string + +const ( + REST CatalogType = "rest" + Hive CatalogType = "hive" + Glue CatalogType = "glue" + DynamoDB CatalogType = "dynamodb" + SQL CatalogType = "sql" +) + +var ( + // ErrNoSuchTable is returned when a table does not exist in the catalog. + ErrNoSuchTable = errors.New("table does not exist") +) + +// WithAwsConfig sets the AWS configuration for the catalog. +func WithAwsConfig(cfg aws.Config) Option { + return func(o *Options) { + o.awsConfig = cfg + } +} + +type Option func(*Options) + +type Options struct { + awsConfig aws.Config +} + +// Catalog for iceberg table operations like create, drop, load, list and others. +type Catalog interface { + // ListTables returns a list of table identifiers in the catalog, with the returned + // identifiers containing the information required to load the table via that catalog. + ListTables(ctx context.Context, namespace table.Identifier) ([]table.Identifier, error) Review Comment: @jackye1995 yeah I think that `Identifier` will need to moved at some point, either to the root namespace being `iceberg`, which is a common convention, or somewhere else to avoid cyclic dependencies which will happen as this evolves. Good call out, and something I did want to chat with @zeroshade about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
