Fokko commented on code in PR #51:
URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1466118740


##########
catalog/glue.go:
##########
@@ -0,0 +1,186 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package catalog
+
+import (
+       "context"
+       "errors"
+       "fmt"
+
+       "github.com/apache/iceberg-go/io"
+       "github.com/apache/iceberg-go/table"
+       "github.com/aws/aws-sdk-go-v2/aws"
+       "github.com/aws/aws-sdk-go-v2/service/glue"
+       "github.com/aws/aws-sdk-go-v2/service/glue/types"
+)
+
+const glueTableTypeIceberg = "ICEBERG"
+
+var (
+       _ Catalog = (*GlueCatalog)(nil)
+)
+
+type glueAPI interface {
+       GetTable(ctx context.Context, params *glue.GetTableInput, optFns 
...func(*glue.Options)) (*glue.GetTableOutput, error)
+       GetTables(ctx context.Context, params *glue.GetTablesInput, optFns 
...func(*glue.Options)) (*glue.GetTablesOutput, error)

Review Comment:
   I think `LoadTable` is clearer, as I generally try to avoid `Get` in the 
name. Why do we need `GetTables`? Wouldn't calling LoadTable multiple times 
give the same result? This also ties in with the comment on `ErrNoSuchTable` 
above; if we don't give the table name in the exception, you don't know which 
one doesn't exists.



##########
catalog/catalog.go:
##########
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package catalog
+
+import (
+       "context"
+       "errors"
+
+       "github.com/apache/iceberg-go/table"
+       "github.com/aws/aws-sdk-go-v2/aws"
+)
+
+type CatalogType string
+
+const (
+       REST     CatalogType = "rest"
+       Hive     CatalogType = "hive"
+       Glue     CatalogType = "glue"
+       DynamoDB CatalogType = "dynamodb"
+       SQL      CatalogType = "sql"
+)
+
+var (
+       // ErrNoSuchTable is returned when a table does not exist in the 
catalog.
+       ErrNoSuchTable = errors.New("table does not exist")

Review Comment:
   I'm not a go expert, but typically we do something like:
   ```suggestion
        ErrNoSuchTable = errors.New("Table does not exist: 
{namespace.table_name}")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to