nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1458875264
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcUtil.java:
##########
@@ -26,6 +26,88 @@
public class TestJdbcUtil {
+ @Test
+ public void testGetTableOrViewSql() {
+ String tableSql = JdbcUtil.getTableOrViewSql(true);
+ Assertions.assertThat(tableSql)
+ .isEqualTo(
+ "SELECT * FROM iceberg_tables WHERE catalog_name = ? AND
table_namespace = ? AND table_name = ?");
+ String viewSql = JdbcUtil.getTableOrViewSql(false);
+ Assertions.assertThat(viewSql)
+ .isEqualTo(
+ "SELECT * FROM iceberg_views WHERE catalog_name = ? AND
view_namespace = ? AND view_name = ?");
+ }
+
+ @Test
+ public void testGetTableOrViewNamespaceSql() {
+ String tableSql = JdbcUtil.getTableNamespaceSql();
Review Comment:
I think this variable and `viewSql` can both be in-lined into
`assertThat(..)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
