nastra commented on code in PR #9487:
URL: https://github.com/apache/iceberg/pull/9487#discussion_r1458859034
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -303,6 +287,325 @@ public static Properties
filterAndRemovePrefix(Map<String, String> properties, S
return result;
}
+ static String getTableOrViewSql(boolean table) {
Review Comment:
+1 on having package-private `getTableSql()` / `getViewSql()`. Also I would
rename `boolean table` to `boolean isTable`everywhere
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -303,6 +287,325 @@ public static Properties
filterAndRemovePrefix(Map<String, String> properties, S
return result;
}
+ static String getTableOrViewSql(boolean table) {
Review Comment:
+1 on having package-private `getTableSql()` / `getViewSql()` methods. Also
I would rename `boolean table` to `boolean isTable`everywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
