Fokko commented on code in PR #51: URL: https://github.com/apache/iceberg-go/pull/51#discussion_r1458500051
########## catalog/catalog.go: ########## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package catalog + +import ( + "context" + "errors" + + "github.com/apache/iceberg-go/table" +) + +type CatalogType string + +const ( + REST CatalogType = "rest" + Hive CatalogType = "hive" + Glue CatalogType = "glue" + DynamoDB CatalogType = "dynamodb" + SQL CatalogType = "sql" +) + +var ( + // ErrNoSuchTable is returned when a table does not exist in the catalog. + ErrNoSuchTable = errors.New("table does not exist") +) + +// Catalog for iceberg table operations like create, drop, load, list and others. +type Catalog interface { + GetTable(ctx context.Context, identifier table.Identifier) (CatalogTable, error) + ListTables(ctx context.Context, identifier table.Identifier) ([]CatalogTable, error) + LoadTable(ctx context.Context, table CatalogTable) (*table.Table, error) + CatalogType() CatalogType +} + +// CatalogTable is the details of a table in a catalog. +type CatalogTable struct { + Identifier table.Identifier // this identifier may vary depending on the catalog implementation + Location string // URL to the table location + CatalogType CatalogType +} Review Comment: Maybe good to align on other implementations here. [PyIceberg](https://github.com/apache/iceberg-python/blob/94d7821cbc6b31b791e18d4f91c0991684616076/pyiceberg/table/__init__.py#L791-L796) for example where we keep a reference to the actual catalog. This makes it easier later on to do a refresh or commit. ```suggestion type Table struct { Identifier table.Identifier // this identifier may vary depending on the catalog implementation Location string // URL to the table location CatalogType CatalogType } ``` In Iceberg everything is very much centered around catalogs, so the `Catalog` is more or less implied. Next to the `Table`, there is the `StaticTable` that directly loads from an URL, but is read-only. ########## catalog/glue.go: ########## @@ -0,0 +1,168 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package catalog + +import ( + "context" + "errors" + "fmt" + + "github.com/apache/iceberg-go/io" + "github.com/apache/iceberg-go/table" + "github.com/aws/aws-sdk-go-v2/aws" + "github.com/aws/aws-sdk-go-v2/service/glue" + "github.com/aws/aws-sdk-go-v2/service/glue/types" +) + +var ( + _ Catalog = (*GlueCatalog)(nil) +) + +type GlueAPI interface { + GetTable(ctx context.Context, params *glue.GetTableInput, optFns ...func(*glue.Options)) (*glue.GetTableOutput, error) + GetTables(ctx context.Context, params *glue.GetTablesInput, optFns ...func(*glue.Options)) (*glue.GetTablesOutput, error) +} + +type GlueCatalog struct { + glueSvc GlueAPI +} + +func NewGlueCatalog(awscfg aws.Config) *GlueCatalog { + return &GlueCatalog{ + glueSvc: glue.NewFromConfig(awscfg), + } +} + +// GetTable loads a table from the Glue Catalog using the given database and table name. +func (c *GlueCatalog) GetTable(ctx context.Context, identifier table.Identifier) (CatalogTable, error) { Review Comment: I think the naming is a bit confusing here. In other implementations, we use `LoadTable` to load the table from an identifier. The `LoadTable` here seems to refresh the table metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
