wolfeidau opened a new pull request, #51: URL: https://github.com/apache/iceberg-go/pull/51
This PR adds an implementation of the catalog which is heavily inspired by iceberg-python, I have tried to keep it as minimal as possible to start somewhere, and get feedback. This includes coverage for all the glue related operations which can be easily mocked, with some discussion needed around testing of the s3 access. I am doing my best to follow the conventions in the existing code, with a few things needing discussion: 1. The table identifier is a bit confusing, I have done my best to follow the python structure in the catalog. 2. Need to do a bit of work around testing combined glue and s3 access, maybe start by exposing a way to load the s3fs directly so we can pass in a mock to test `LoadTable`. I can easily use this as a basis for the dynamodb catalog, which would enable running both the iofs and catalog locally in an integration test environment at some point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
