liurenjie1024 commented on code in PR #167:
URL: https://github.com/apache/iceberg-rust/pull/167#discussion_r1454897761
##########
Makefile:
##########
@@ -32,7 +32,11 @@ cargo-sort:
cargo install cargo-sort
cargo sort -c -w
-check: check-fmt check-clippy cargo-sort
+fmt-toml:
+ cargo install taplo-cli --locked
+ taplo fmt
Review Comment:
> I'm guessing not. It will fmt the files directly if it used to be
incorrectly formatted.
Than I think it's better to use `check` here. The goal of ci is to check the
correctness, not do formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
