Xuanwo commented on code in PR #167:
URL: https://github.com/apache/iceberg-rust/pull/167#discussion_r1454871958
##########
Makefile:
##########
@@ -32,7 +32,11 @@ cargo-sort:
cargo install cargo-sort
cargo sort -c -w
-check: check-fmt check-clippy cargo-sort
+fmt-toml:
+ cargo install taplo-cli --locked
+ taplo fmt
Review Comment:
> I mean, `fmt` does both check and formatting, will it return non 0 exit
code when incorrectly formatted?
I'm guessing not. It will fmt the files directly if it used to be
incorrectly formatted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
