nastra commented on code in PR #8988:
URL: https://github.com/apache/iceberg/pull/8988#discussion_r1443018102
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -2181,20 +2181,28 @@ public void testTableWithInt96Timestamp() throws
IOException {
stagingLocation);
// validate we get the expected results back
- List<Row> expected =
spark.table("parquet_table").select("tmp_col").collectAsList();
- List<Row> actual =
- spark
- .read()
- .format("iceberg")
- .load(loadLocation(tableIdentifier))
- .select("tmp_col")
- .collectAsList();
- assertThat(actual).as("Rows must
match").containsExactlyInAnyOrderElementsOf(expected);
+ testWithFilter("tmp_col < to_timestamp('2000-01-31 08:30:00')",
tableIdentifier);
Review Comment:
these tests are all passing without the fix. Can you please add a test that
reproduces the issue from https://github.com/apache/iceberg/issues/8990?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
