rdblue commented on code in PR #9384:
URL: https://github.com/apache/iceberg/pull/9384#discussion_r1439722314
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -334,6 +335,9 @@ private TableProperties() {}
public static final String MAX_REF_AGE_MS = "history.expire.max-ref-age-ms";
public static final long MAX_REF_AGE_MS_DEFAULT = Long.MAX_VALUE;
+ public static final String DELETE_GRANULARITY = "write.delete.granularity";
Review Comment:
This option makes no sense for equality deletes because they aren't targeted
at a single file, so I agree that we won't support it for equality. This is
also mostly advisory. It is unlikely that we will support it in Flink and will
instead always use file-level granularity. Maybe we won't even want to support
this in the long term, if we decide that Spark performs better with file
granularity at all times.
I guess where I'm at for this is that I would probably not worry much about
it -- but also not add it to documentation since we will probably not want
people setting it themselves. I think I'd leave it as
`write.delete.granularity`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
