aokolnychyi commented on code in PR #9384:
URL: https://github.com/apache/iceberg/pull/9384#discussion_r1439685145


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -334,6 +335,9 @@ private TableProperties() {}
   public static final String MAX_REF_AGE_MS = "history.expire.max-ref-age-ms";
   public static final long MAX_REF_AGE_MS_DEFAULT = Long.MAX_VALUE;
 
+  public static final String DELETE_GRANULARITY = "write.delete.granularity";

Review Comment:
   To be honest, I doubt we will ever support this property for equality 
deletes.
   
   In general, I do get that we may want to configure position and equality 
deletes differently. We can explore adding an extra namespace. I am still not 
sure this use case falls into that bucket.
   
   @rdblue @RussellSpitzer @zhongyujiang, thoughts? Do we want a prefix for 
this config to make it explicit that it only applies to position deletes? 
Currently, I only note that in the docs.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to