Fokko commented on code in PR #9366:
URL: https://github.com/apache/iceberg/pull/9366#discussion_r1439066996
##########
core/src/main/java/org/apache/iceberg/avro/ValueReaders.java:
##########
@@ -381,6 +550,45 @@ public BigDecimal read(Decoder decoder, Object ignored)
throws IOException {
byte[] bytes = bytesReader.read(decoder, null);
return new BigDecimal(new BigInteger(bytes), scale);
}
+
+ @Override
+ public void skip(Decoder decoder) throws IOException {
+ bytesReader.skip(decoder);
+ }
+ }
+
+ private static class RequiredOptionReader implements ValueReader<Object> {
Review Comment:
I would remove it, the PR looks good, so feel free to merge it once the
tests are green 👍
##########
core/src/main/java/org/apache/iceberg/avro/ValueReaders.java:
##########
@@ -381,6 +550,45 @@ public BigDecimal read(Decoder decoder, Object ignored)
throws IOException {
byte[] bytes = bytesReader.read(decoder, null);
return new BigDecimal(new BigInteger(bytes), scale);
}
+
+ @Override
+ public void skip(Decoder decoder) throws IOException {
+ bytesReader.skip(decoder);
+ }
+ }
+
+ private static class RequiredOptionReader implements ValueReader<Object> {
Review Comment:
Thanks for the context. I would remove it, the PR looks good, so feel free
to merge it once the tests are green 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
