rdblue commented on code in PR #9366:
URL: https://github.com/apache/iceberg/pull/9366#discussion_r1439066126
##########
core/src/main/java/org/apache/iceberg/avro/ValueReaders.java:
##########
@@ -381,6 +550,45 @@ public BigDecimal read(Decoder decoder, Object ignored)
throws IOException {
byte[] bytes = bytesReader.read(decoder, null);
return new BigDecimal(new BigInteger(bytes), scale);
}
+
+ @Override
+ public void skip(Decoder decoder) throws IOException {
+ bytesReader.skip(decoder);
+ }
+ }
+
+ private static class RequiredOptionReader implements ValueReader<Object> {
Review Comment:
This is actually unused so we could remove it. The purpose is to be able to
replace the union reader with one that checks that the value is non-null for
cases where the file has an optional field but the expected schema requires it.
With Iceberg's schema evolution rules, we should never have that case, which
is why I didn't end up using this (it was complicated and of little value). But
I included the class just in case we want it in the future.
It would be good to hear what you think. Should we keep or remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
