nastra commented on code in PR #9364:
URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435806758
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java:
##########
@@ -134,8 +130,7 @@ private Table createPrimitiveTable() throws IOException {
createPrimitiveRecord(
false, 2, 2L, Float.NaN, 2.0D, new BigDecimal("2.00"), "2",
null, null));
- DataFile dataFile =
- FileHelpers.writeDataFile(table, Files.localOutput(temp.newFile()),
records);
+ DataFile dataFile = FileHelpers.writeDataFile(table,
Files.localOutput(temp.toFile()), records);
Review Comment:
this should be doing `File.createTempFile("junit", null, temp.toFile())`
instead of `temp.toFile()`, similar to how it was done in #9341. The same needs
to be done in L151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
