nastra commented on code in PR #9364: URL: https://github.com/apache/iceberg/pull/9364#discussion_r1435806371
########## flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestMetadataTableReadableMetrics.java: ########## @@ -76,7 +72,7 @@ protected TableEnvironment getTableEnv() { return super.getTableEnv(); } - @Rule public TemporaryFolder temp = new TemporaryFolder(); + @TempDir Path temp; Review Comment: this can be private (unless there's a subclass that might use this) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org