tmnd1991 commented on PR #9233: URL: https://github.com/apache/iceberg/pull/9233#issuecomment-1867382578
> > I ran `TestSPJWithBucketing` on Spark 3.4 and I do see that `testMergeSPJwithCondition` passes and `testMergeSPJwithoutCondition` does not (on Spark 3.5 both fail). I believe that the reason the test results are different between Spark 3.4 and 3.5 is > > ``` > > % diff spark/v3.4/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceStaticInvoke.scala spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceStaticInvoke.scala > > 25a26 > > > import org.apache.spark.sql.catalyst.plans.FullOuter > > 61c62 > > < case j @ Join(_, _, _, Some(condition), _) => > > --- > > > case j @ Join(_, _, FullOuter, Some(condition), _) => > > ``` > > I was wrong in the above hypothesis. Nevertheless, why the difference in `ReplaceStaticInvoke` between Spark 3.4 and 3.5? It was just me playing around, now they are identical, but the test results are the same as before (i.e. different between 3.4 and 3.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
