tmnd1991 commented on PR #9233: URL: https://github.com/apache/iceberg/pull/9233#issuecomment-1866004074
> The main in my local clone is at [d6eba2a](https://github.com/apache/iceberg/commit/d6eba2a2b6ecf76dc11910d88febca6c4833338d). I applied the diff from this PR to my local main. The `TestSPJWithBucketing` added fails for me: > > ``` > > Task :iceberg-spark:iceberg-spark-extensions-3.5_2.12:test > > org.apache.iceberg.spark.extensions.TestSPJWithBucketing > testMergeSPJwithoutCondition[catalogName = testhive, implementation = org.apache.iceberg.spark.SparkCatalog, config = {type=hive, default-namespace=default}] FAILED > org.opentest4j.AssertionFailedError: > expected: 12 > but was: 18 > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) > at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at org.apache.iceberg.spark.extensions.TestSPJWithBucketing.testWithCondition(TestSPJWithBucketing.java:85) > at org.apache.iceberg.spark.extensions.TestSPJWithBucketing.testMergeSPJwithoutCondition(TestSPJWithBucketing.java:55) > > org.apache.iceberg.spark.extensions.TestSPJWithBucketing > testMergeSPJwithCondition[catalogName = testhive, implementation = org.apache.iceberg.spark.SparkCatalog, config = {type=hive, default-namespace=default}] FAILED > org.opentest4j.AssertionFailedError: > expected: 12 > but was: 15 > at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) > at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) > at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) > at org.apache.iceberg.spark.extensions.TestSPJWithBucketing.testWithCondition(TestSPJWithBucketing.java:85) > at org.apache.iceberg.spark.extensions.TestSPJWithBucketing.testMergeSPJwithCondition(TestSPJWithBucketing.java:44) > > 2 tests completed, 2 failed > > > Task :iceberg-spark:iceberg-spark-extensions-3.5_2.12:test FAILED > ``` > > Same with 3.4. > > I assume the test is expected to pass with the changes in `ReplaceStaticInvoke` in this PR. In other words, the test should fail without the changes in `ReplaceStaticInvoke` in this PR and should pass with them. I just rebased and tested on top of latest main (2eea697297a4c724a950a4bdc9dd29822ea90d8c) and I have all tests (TestSPJWithBucketing) failing on 3.5, while on 3.4 testMergeSPJwithCondition passes and testMergeSPJwithoutCondition does not (and that is expected to me, because merge/SPJ is not smart enough imho, so with the guidance on the condition it works, otherwise it does not). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
