nastra commented on code in PR #9341:
URL: https://github.com/apache/iceberg/pull/9341#discussion_r1434196954
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java:
##########
@@ -272,20 +274,22 @@ private Dataset<Row> createDataset(Iterable<Record>
records, Schema schema) thro
assertEqualsUnsafe(schema.asStruct(), recordIter.next(), row);
rows.add(row);
}
- Assert.assertEquals(
- "Both iterators should be exhausted", recordIter.hasNext(),
readIter.hasNext());
+ assertThat(readIter.hasNext())
+ .as("Both iterators should be exhausted")
+ .isEqualTo(recordIter.hasNext());
}
JavaRDD<InternalRow> rdd = sc.parallelize(rows);
return spark.internalCreateDataFrame(JavaRDD.toRDD(rdd), convert(schema),
false);
}
- @Test
+ @TestTemplate
public void testNullableWithWriteOption() throws IOException {
- Assume.assumeTrue(
- "Spark 3 rejects writing nulls to a required column",
spark.version().startsWith("2"));
+ assumeThat(spark.version())
+ .as("Spark 3 rejects writing nulls to a required column")
+ .startsWith("2");
- File location = new File(temp.newFolder("parquet"), "test");
+ File location = new File(new File(temp.toFile(), "parquet"), "test");
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
