nastra commented on code in PR #9341:
URL: https://github.com/apache/iceberg/pull/9341#discussion_r1434196320
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java:
##########
@@ -144,10 +143,10 @@ protected void writeAndValidate(Schema schema) throws
IOException {
writeAndValidateWithLocations(table, location, new File(location, "data"));
}
- @Test
+ @TestTemplate
public void testWriteWithCustomDataLocation() throws IOException {
File location = createTableFolder();
- File tablePropertyDataLocation =
temp.newFolder("test-table-property-data-dir");
+ File tablePropertyDataLocation = new File(temp.toFile(),
"test-table-property-data-dir");
Review Comment:
same as above
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWrites.java:
##########
@@ -157,9 +156,9 @@ public void testWriteWithCustomDataLocation() throws
IOException {
}
private File createTableFolder() throws IOException {
- File parent = temp.newFolder("parquet");
+ File parent = new File(temp.toFile(), "parquet");
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
