Fokko commented on code in PR #227:
URL: https://github.com/apache/iceberg-python/pull/227#discussion_r1433110149
##########
tests/io/test_pyarrow_visitor.py:
##########
@@ -209,9 +209,9 @@ def test_pyarrow_variable_binary_to_iceberg() -> None:
def test_pyarrow_struct_to_iceberg() -> None:
pyarrow_struct = pa.struct(
[
- pa.field("foo", pa.string(), nullable=True, metadata={"field_id":
"1", "doc": "foo doc"}),
- pa.field("bar", pa.int32(), nullable=False, metadata={"field_id":
"2"}),
- pa.field("baz", pa.bool_(), nullable=True, metadata={"field_id":
"3"}),
+ pa.field("foo", pa.string(), nullable=True,
metadata={PYARROW_FIELD_ID_KEY: "1", "doc": "foo doc"}),
Review Comment:
Sounds good, updated 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
