Fokko commented on code in PR #227: URL: https://github.com/apache/iceberg-python/pull/227#discussion_r1433109602
########## pyiceberg/io/pyarrow.py: ########## @@ -154,10 +154,9 @@ ONE_MEGABYTE = 1024 * 1024 BUFFER_SIZE = "buffer-size" ICEBERG_SCHEMA = b"iceberg.schema" -FIELD_ID = "field_id" -DOC = "doc" -PYARROW_FIELD_ID_KEYS = [b"PARQUET:field_id", b"field_id"] -PYARROW_FIELD_DOC_KEYS = [b"PARQUET:field_doc", b"field_doc", b"doc"] +# The PARQUET: in front means that it is Parquet specific, in this case the field_id +PYARROW_FIELD_ID_KEY = b"PARQUET:field_id" Review Comment: Thanks, that's a good point! I've updated the code 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
