pvary commented on code in PR #9346: URL: https://github.com/apache/iceberg/pull/9346#discussion_r1432578931
##########
docs/flink-configuration.md:
##########
@@ -133,7 +133,8 @@ env.getConfig()
| max-planning-snapshot-count |
connector.iceberg.max-planning-snapshot-count | N/A
| Integer.MAX_VALUE | Max number of snapshots limited per split
enumeration. Applicable only to streaming read.
|
| limit | connector.iceberg.limit
| N/A | -1 | Limited
output number of rows.
|
| max-allowed-planning-failures |
connector.iceberg.max-allowed-planning-failures | N/A
| 3 | Max allowed consecutive failures for scan
planning before failing the job. Set to -1 for never failing the job for scan
planing failure.
|
-
+| watermark-column | connector.iceberg.watermark-column
| N/A | null |
Specifies the watermark column to use for watermark generation.
|
+| watermark-timeunit | connector.iceberg.watermark-timeunit
| N/A | TimeUnit.MICROSECONDS |
Specifies the watermark time unit to use for watermark generation.
|
Review Comment:
Could we describe to possible values? What should the user write in the
option string to get the desired result? Something like: `The possible values
are
DAYS, HOURS, MINUTES, SECONDS, MILLISECONDS, MICROSECONDS, NANOSECONDS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
