nastra commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1431007132


##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java:
##########
@@ -221,6 +221,22 @@ public void testBasicCatalog() throws Exception {
     Assertions.assertThat(fs.isDirectory(new Path(metaLocation))).isFalse();
   }
 
+  @Test
+  public void testHadoopFileIOProperties() {
+    TableIdentifier tableIdent = TableIdentifier.of("db", "ns1", "ns2", "tbl");
+    ImmutableMap<String, String> catalogProps =
+        ImmutableMap.of(
+            "warehouse", "/hive/testwarehouse",
+            "io.manifest.cache-enabled", "true");
+
+    HadoopCatalog catalog = new HadoopCatalog();
+    catalog.initialize("hadoop", catalogProps);
+    FileIO fileIO = catalog.newTableOps(tableIdent).io();
+
+    
Assertions.assertThat(fileIO.properties().get("warehouse")).isEqualTo("/hive/testwarehouse");
+    
Assertions.assertThat(fileIO.properties().get("io.manifest.cache-enabled")).isEqualTo("true");

Review Comment:
   ```suggestion
       
Assertions.assertThat(fileIO.properties()).containsEntry("io.manifest.cache-enabled",
 "true");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to