amogh-jahagirdar commented on code in PR #9283:
URL: https://github.com/apache/iceberg/pull/9283#discussion_r1425696907
##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java:
##########
@@ -112,11 +112,11 @@ public void initialize(String name, Map<String, String>
properties) {
this.warehouseLocation =
LocationUtil.stripTrailingSlash(inputWarehouseLocation);
this.fs = Util.getFs(new Path(warehouseLocation), conf);
- String fileIOImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
- this.fileIO =
- fileIOImpl == null
- ? new HadoopFileIO(conf)
- : CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
+ String fileIOImpl =
+ properties.getOrDefault(
+ CatalogProperties.FILE_IO_IMPL,
"org.apache.iceberg.hadoop.HadoopFileIO");
+
+ this.fileIO = CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
Review Comment:
Is it possible to add a test to validate that properties get set on the
HadoopFileIO instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
