pvary commented on PR #9308: URL: https://github.com/apache/iceberg/pull/9308#issuecomment-1861356815
> BTW, should we add an integration test? That reminds me, to remove the `set(PipelineOptions.ALLOW_UNALIGNED_SOURCE_SPLITS, true)` from the `TestIcebergSourceWithWatermarkExtractor` test. That is how I have found this issue. The `TestIcebergSourceWithWatermarkExtractor.testThrottling` was slightly flaky because of this change (1 out of 1000), but I do not see any other good way to integration test it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
