pvary commented on PR #9308:
URL: https://github.com/apache/iceberg/pull/9308#issuecomment-1859147694

   @stevenzwu: Here is what I have found:
   `wakeUp` is called whenever there is a new message concerning the 
`SplitReader`:
   - new split added/removed
   - split paused/resumed
   
   These messages are executed in the same thread as the fetch method, so in 
this case we have to return from the fetch loop, even with empty results. This 
is somewhat concerning to me considering the comment here:
   
https://github.com/apache/iceberg/blob/820fc3ceda386149f42db8b54e6db9171d1a3a6d/flink/v1.18/flink/src/main/java/org/apache/iceberg/flink/source/reader/IcebergSourceSplitReader.java#L76-L78
   
   I do not see that it is closed, but probably you know more...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to