BsoBird commented on code in PR #9333:
URL: https://github.com/apache/iceberg/pull/9333#discussion_r1430084523


##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -129,7 +130,7 @@ public TableMetadata refresh() {
 
   @Override
   public void commit(TableMetadata base, TableMetadata metadata) {
-    Pair<Integer, TableMetadata> current = versionAndMetadata();
+    Pair<Long, TableMetadata> current = versionAndMetadata();

Review Comment:
   Yes, I just thought that versionId defined as integer type is easy to 
overflow, so I changed it to long type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to