ajantha-bhat commented on code in PR #9284:
URL: https://github.com/apache/iceberg/pull/9284#discussion_r1423868004
##########
core/src/main/java/org/apache/iceberg/ReachableFileUtil.java:
##########
@@ -148,12 +148,49 @@ public static List<String> statisticsFilesLocations(Table
table) {
* @param table table for which statistics files needs to be listed
* @param predicate predicate for filtering the statistics files
* @return the location of statistics files
+ * @deprecated use the {@code statisticsFilesLocationsForSnapshots(table,
snapshotIds)} instead.
*/
+ @Deprecated
Review Comment:
can't use the `Predicate<StatisticsFile>` for partition stats. Hence,
deprecated and introduced snapshot id based input like other methods in this
class (manifest list, manifest etc)
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestExpireSnapshotsProcedure.java:
##########
@@ -475,18 +474,9 @@ public void testExpireSnapshotsWithStatisticFiles() throws
Exception {
Assertions.assertThat(output.get(0)[5]).as("should be 1 deleted statistics
file").isEqualTo(1L);
table.refresh();
- List<StatisticsFile> statsWithSnapshotId1 =
Review Comment:
Since we are checking `containsExactly` at line 482, no need of these
checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
