stevenzwu commented on code in PR #9212:
URL: https://github.com/apache/iceberg/pull/9212#discussion_r1419739020
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/sink/shuffle/TestDataStatisticsOperator.java:
##########
@@ -119,9 +121,9 @@ public void testProcessElement() throws Exception {
testHarness = createHarness(this.operator)) {
StateInitializationContext stateContext = getStateContext();
operator.initializeState(stateContext);
- operator.processElement(new
StreamRecord<>(GenericRowData.of(StringData.fromString("a"))));
- operator.processElement(new
StreamRecord<>(GenericRowData.of(StringData.fromString("a"))));
- operator.processElement(new
StreamRecord<>(GenericRowData.of(StringData.fromString("b"))));
+ operator.processElement(new StreamRecord<>(genericRowDataA));
+ operator.processElement(new StreamRecord<>(genericRowDataA));
Review Comment:
do you mean not reusing the object? if yes, I would just get rid of the
pre-constructed objects and always construct them on the fly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
