stevenzwu commented on code in PR #9212:
URL: https://github.com/apache/iceberg/pull/9212#discussion_r1418105469
##########
flink/v1.17/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceWithWatermarkExtractor.java:
##########
@@ -92,7 +93,10 @@ public class TestIcebergSourceWithWatermarkExtractor
implements Serializable {
.setNumberTaskManagers(1)
.setNumberSlotsPerTaskManager(PARALLELISM)
.setRpcServiceSharing(RpcServiceSharing.DEDICATED)
- .setConfiguration(reporter.addToConfiguration(new
Configuration()))
+ .setConfiguration(
+ reporter.addToConfiguration(
+ // disable classloader check as Avro may cache class in
the serializers.
+ new
Configuration().set(CoreOptions.CHECK_LEAKED_CLASSLOADER, false)))
Review Comment:
this was merged by PR #9216 . I included it earlier before the separate PR
was merged.
> Would it worth/possible to have a common place for this, so we will not
forget it in future tests?
maybe we can think about refactoring MiniClusterResource? but it is out of
scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
