RussellSpitzer commented on code in PR #9236:
URL: https://github.com/apache/iceberg/pull/9236#discussion_r1417914889


##########
core/src/test/java/org/apache/iceberg/util/TestStructLikeMap.java:
##########
@@ -147,4 +149,32 @@ public void testKeysWithNulls() {
 
     assertThat(map.remove(record3)).isEqualTo("aaa");
   }
+
+  @Test
+  public void testEqualsAndHashCode() {

Review Comment:
   Can we do a quick addition of a test for empty map equality? I am pretty 
sure that is fine but just to be complete



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to