aokolnychyi commented on code in PR #9236:
URL: https://github.com/apache/iceberg/pull/9236#discussion_r1417901732
##########
core/src/main/java/org/apache/iceberg/util/StructLikeMap.java:
##########
@@ -146,25 +145,19 @@ public R getValue() {
@Override
public int hashCode() {
- int hashCode = getKey().hashCode();
- if (getValue() != null) {
- hashCode ^= getValue().hashCode();
- }
- return hashCode;
+ return inner.hashCode();
}
@Override
- @SuppressWarnings("unchecked")
public boolean equals(Object o) {
if (this == o) {
return true;
- } else if (!(o instanceof StructLikeEntry)) {
+ } else if (o == null || getClass() != o.getClass()) {
return false;
- } else {
- StructLikeEntry that = (StructLikeEntry<R>) o;
- return Objects.equals(getKey(), that.getKey())
Review Comment:
We used `getKey()` which unwrapped the object and we were loosing proper
equality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
