jasonf20 opened a new pull request, #9230: URL: https://github.com/apache/iceberg/pull/9230
Since the following PR: https://github.com/apache/iceberg/pull/6335 FastAppend and subclasses of MergingSnapshotProducer will skip newly added data files during retries. This happens because the cached value is set to an empty list instead of null and then if commit is called again, when `newDataFilesAsManifests` is called the logic is skipped and no data files are returned. This commit fixes the issue and adds some tests that fail without the fix. See https://github.com/apache/iceberg/pull/9222#issuecomment-1841301960 for an earlier discussion. Initially, I thought this bug should be solved with validation but upon further discussion, I am re-submitting this with tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
