jasonf20 commented on code in PR #9222:
URL: https://github.com/apache/iceberg/pull/9222#discussion_r1416968091
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -188,7 +188,7 @@ protected void cleanUncommitted(Set<ManifestFile>
committed) {
}
}
- this.newManifests = committedNewManifests;
Review Comment:
Good catch I just applied the same pattern from `newDataFilesAsManifests`
and didn't notice this difference.
Let me know if you want me to fix this or if you think this problem should
be fixed by validation instead. i.e. should re-calling commit be allowed in
user code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
