nastra commented on code in PR #9131:
URL: https://github.com/apache/iceberg/pull/9131#discussion_r1415086590
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -173,6 +173,10 @@ public Long snapshotId() {
return snapshotId;
}
+ public String branch() {
+ return branch;
Review Comment:
it is effectively final as it's only set once. However, it's not marked as
`final` due to the way the different constructors in `SparkTable` are called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
