nastra commented on code in PR #9131:
URL: https://github.com/apache/iceberg/pull/9131#discussion_r1403420355
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -171,7 +171,7 @@ public Table loadTable(Identifier ident, String version)
throws NoSuchTableExcep
SparkTable sparkTable = (SparkTable) table;
Preconditions.checkArgument(
- sparkTable.snapshotId() == null,
+ sparkTable.snapshotId() == null && sparkTable.branch() == null,
Review Comment:
I'm not sure whether we actually want to fix this as part of this PR or a
separate PR, but in the Iceberg sync we briefly talked about making sure that
`SELECT * from ns.table.branch_x VERSION AS OF ...` shouldn't be supported and
should throw an error, which is what this check is doing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
