amogh-jahagirdar commented on code in PR #9183:
URL: https://github.com/apache/iceberg/pull/9183#discussion_r1414245847
##########
core/src/test/java/org/apache/iceberg/TestSequenceNumberForV2Table.java:
##########
@@ -309,6 +309,8 @@ public void testExpirationInTransaction() {
V2Assert.assertEquals("Snapshot sequence number should be 1", 1,
snap1.sequenceNumber());
V2Assert.assertEquals(
"Last sequence number should be 1", 1,
readMetadata().lastSequenceNumber());
+ V2Assert.assertEquals(
+ "Should be 1 manifest list file", 1,
listManifestListFiles(table.location()).size());
Review Comment:
Nit: could we just call it "manifest list" (the file is a bit redundant)
so the assertion message would be "Should be 1 manifest list"
##########
core/src/test/java/org/apache/iceberg/TestSequenceNumberForV2Table.java:
##########
@@ -319,12 +321,18 @@ public void testExpirationInTransaction() {
V2Assert.assertEquals("Snapshot sequence number should be 2", 2,
snap2.sequenceNumber());
V2Assert.assertEquals(
"Last sequence number should be 2", 2,
readMetadata().lastSequenceNumber());
+ V2Assert.assertEquals(
+ "Should be 2 manifest list files", 2,
listManifestListFiles(table.location()).size());
Transaction txn = table.newTransaction();
txn.expireSnapshots().expireSnapshotId(commitId1).commit();
txn.commitTransaction();
V2Assert.assertEquals(
"Last sequence number should be 2", 2,
readMetadata().lastSequenceNumber());
+ V2Assert.assertEquals(
+ "Should be 1 manifest list file as 1 was deleted",
Review Comment:
Same as above: "Should be 1 manifest list"
##########
core/src/test/java/org/apache/iceberg/TestSequenceNumberForV2Table.java:
##########
@@ -319,12 +321,18 @@ public void testExpirationInTransaction() {
V2Assert.assertEquals("Snapshot sequence number should be 2", 2,
snap2.sequenceNumber());
V2Assert.assertEquals(
"Last sequence number should be 2", 2,
readMetadata().lastSequenceNumber());
+ V2Assert.assertEquals(
+ "Should be 2 manifest list files", 2,
listManifestListFiles(table.location()).size());
Review Comment:
Nit: "Should be 2 manifest lists"
##########
core/src/test/java/org/apache/iceberg/TableTestBase.java:
##########
@@ -212,6 +212,15 @@ List<File> listManifestFiles(File tableDirToList) {
&&
Files.getFileExtension(name).equalsIgnoreCase("avro")));
}
+ List<File> listManifestListFiles(String tableDirToList) {
Review Comment:
Nit: listManifestLists for the function name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
