lisirrx commented on code in PR #9161:
URL: https://github.com/apache/iceberg/pull/9161#discussion_r1413411369
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java:
##########
@@ -156,22 +156,22 @@ public class TestDictionaryRowGroupFilter {
private MessageType parquetSchema = null;
private BlockMetaData rowGroupMetadata = null;
private DictionaryPageReadStore dictionaryStore = null;
- private final WriterVersion writerVersion;
-
- @Rule public TemporaryFolder temp = new TemporaryFolder();
-
- @Parameterized.Parameters
- public static List<WriterVersion> writerVersions() {
- return Arrays.asList(PARQUET_1_0, PARQUET_2_0);
+ @Parameter
+ private WriterVersion writerVersion;
+
+ @Parameters(name = "writerVersion={0}")
+ public static Collection<WriterVersion> parameters() {
+ return Arrays.asList(
+ WriterVersion.PARQUET_1_0,
+ WriterVersion.PARQUET_2_0);
}
+
+ @TempDir
+ public Path temp;
- public TestDictionaryRowGroupFilter(WriterVersion writerVersion) {
- this.writerVersion = writerVersion;
- }
-
- @Before
+ @BeforeEach
public void createInputFile() throws IOException {
- File parquetFile = temp.newFile();
Review Comment:
I encounter the same case in `iceberg-core`. I step into the `newFile`
function and find it create a temp file with prefix `junit`, using
`File.createTempFile`. May be we can use the `File.createTempFile` directly in
our code here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
